Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ui): update to ember 5.7 and latest dependencies #1483

Merged
merged 27 commits into from
Apr 15, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Apr 10, 2024

Description

Packages that were ready to update:

Before

 @ember/optional-features       ^2.0.0  →    ^2.1.0
 @ember/test-helpers            ^2.9.3  →    ^3.3.0
 autoprefixer                 ^10.4.12  →  ^10.4.19
 ember-auto-import              ^2.6.3  →    ^2.7.2
 ember-basic-dropdown           ^7.2.1  →    ^8.0.4
 ember-changeset               ^3.15.0  →    ^4.1.2
 ember-changeset-validations   ^3.16.0  →    ^4.1.1
 ember-cli                      ~4.8.0  →    ~5.7.0
 ember-cli-babel              ^7.26.11  →    ^8.2.0
 ember-cli-flash                ^4.0.0  →    ^5.1.0
 ember-cli-htmlbars             ^6.2.0  →    ^6.3.0
 ember-data                     ~4.9.1  →    ~5.3.3
 ember-page-title               ^7.0.0  →    ^8.2.3
 ember-qunit                    ^6.2.0  →    ^8.0.2
 ember-resolver                 ^9.0.1  →   ^11.0.1
 ember-sortable                 ^5.0.0  →    ^5.0.1
 ember-source                   ~4.8.0  →    ~5.7.0
 ember-template-lint            ^5.7.3  →    ^6.0.0
 ember-truth-helpers            ^3.1.1  →    ^4.0.3
 eslint                        ^7.32.0  →    ^9.0.0
 eslint-config-prettier         ^8.8.0  →    ^9.1.0
 eslint-plugin-ember           ^11.4.6  →   ^12.0.2
 eslint-plugin-prettier         ^4.2.1  →    ^5.1.3
 eslint-plugin-qunit            ^7.3.4  →    ^8.1.1
 postcss-import                ^15.1.0  →   ^16.1.0
 prettier                       ^2.7.1  →    ^3.2.5
 pretty-print-json              ^1.4.1  →    ^3.0.0
 qunit                         ^2.19.4  →   ^2.20.1
 qunit-dom                      ^2.0.0  →    ^3.1.1
 tailwindcss                    ^3.3.1  →    ^3.4.3
 webpack                       ^5.89.0  →   ^5.91.0

After (remaining upgrades)

 ember-basic-dropdown   ^7.3.0  →  ^8.0.4
 ember-data            ~4.12.7  →  ~5.3.3
 ember-template-lint   ^5.13.0  →  ^6.0.0
 eslint                ^8.57.0  →  ^9.0.0

It should fix https://github.com/ConduitIO/conduit/security/dependabot/101.

Eventually

We should tackle remaining dependency updates (especially ember-data), and fix those issues raised by this (currently ignored) rule which has to be with concurrency:

https://github.com/ConduitIO/conduit/pull/1483/files#diff-67374ffae5708e2151619b05053062ca3cac9a8071b22c51d828e6dc7e3d880eR31-R32

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have updated unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb force-pushed the upgrade-dependencies branch from fc6553a to 9c6f481 Compare April 11, 2024 10:32
@raulb raulb changed the title chore: update dependencies feature(ui): update to ember 5.7 and latest dependencies Apr 11, 2024
@raulb raulb self-assigned this Apr 12, 2024
@raulb raulb marked this pull request as ready for review April 12, 2024 13:24
@raulb raulb requested a review from a team April 12, 2024 13:24
@raulb raulb merged commit 98ad6b3 into main Apr 15, 2024
5 checks passed
@raulb raulb deleted the upgrade-dependencies branch April 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants